-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Fix docker in image_id #3481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying and fixing this @Michaelvll ! Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we fix that for node providers as well?
skypilot/sky/skylet/providers/command_runner.py
Lines 236 to 241 in 8a18133
self.run( | |
'sudo jq \'.["exec-opts"] = ["native.cgroupdriver=cgroupfs"]\' ' | |
'/etc/docker/daemon.json > /tmp/daemon.json;' | |
'sudo mv /tmp/daemon.json /etc/docker/daemon.json;' | |
'sudo systemctl restart docker', | |
run_env='host') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this fix does not works for k8s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to the test_docker_preinstalled_package
for k8s. That one is probably because we did not install the required packages in the docker container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! LGTM.
Fixes issue introduced in #3436, as some cloud's default images do not have
/etc/docker/daemon.json
by default, which causes the following error, during initializing docker imageTested (run the relevant ones):
bash format.sh
sky launch -c test-docker --cloud gcp --image-id docker:continuumio/miniconda3:24.1.2-0 echo hi
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_docker_storage_mounts tests/test_smoke.py::test_docker_preinstalled_package --gcp
pytest tests/test_smoke.py::test_docker_storage_mounts tests/test_smoke.py::test_docker_preinstalled_package --aws
pytest tests/test_smoke.py::test_docker_storage_mounts tests/test_smoke.py::test_docker_preinstalled_package --azure
pytest tests/test_smoke.py::test_docker_storage_mounts tests/test_smoke.py::test_docker_preinstalled_package --fluidstack
pytest tests/test_smoke.py::test_docker_storage_mounts --kubernetes
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh