[Spot] Refactor spot APIs into spot.xxx
#3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
reviewed
Apr 6, 2024
| """.strip() | ||
|
|
||
|
|
||
| def convert_entrypoint_to_dag(entrypoint: Any) -> 'dag_lib.Dag': |
There was a problem hiding this comment.
code gardening: should we add proper type annotation for entrypoint
There was a problem hiding this comment.
For entrypoint, we check all the other types in the function below. It might be fine for now?
Co-authored-by: Tian Xia <[email protected]>
|
Tested:
|
cblmemo
approved these changes
Apr 9, 2024
| @@ -626,3 +626,20 @@ def fill_template(template_name: str, variables: Dict, | |||
| content = j2_template.render(**variables) | |||
| with open(output_path, 'w', encoding='utf-8') as fout: | |||
| fout.write(content) | |||
|
|
|||
|
|
|||
| def deprecated_function(func: Callable, name: str, deprecated_name: str, | |||
There was a problem hiding this comment.
is there other deprecated function in the system? if so, change to this decorator as well?
There was a problem hiding this comment.
No, I don't think there is any other deprecated functions in the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors spot APIs
core.spot_xxxintospot.xxx.Closes #3283
Blocking #3419
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.py(except test_spot_tpu, test_tpu_vm_pod, and tpu_vm_app due to [Examples] TPU example failexamples/tpu/tpuvm_mnist.yaml#3425)pytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh