Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lambda] Fix lambda cloud provisioning #3409

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[Lambda] Fix lambda cloud provisioning #3409

merged 2 commits into from
Apr 2, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Apr 2, 2024 •
edited
Loading

Fixes #3408

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch --cloud lambda --gpus a10 nvidia-smi
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll mentioned this pull request Apr 2, 2024
Closed
romilbhardwaj
romilbhardwaj approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll!

sky/utils/cluster_yaml_utils.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 86224ac into master Apr 2, 2024
20 checks passed
@Michaelvll Michaelvll deleted the fix-lambda branch April 2, 2024 20:20
@concretevitamin
Copy link
Member

Maybe in the future we can have an aliasing setup, e.g., useful for #2639 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romilbhardwaj romilbhardwaj romilbhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud 'lambda_cloud' is not a valid cloud
3 participants
@Michaelvll @concretevitamin @romilbhardwaj