-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add HOST_CONTROLLERS
check for clouds
#3407
Conversation
clouds.CloudImplementationFeatures.HOST_CONTROLLERS: 'Kubernetes can ' | ||
'not host ' | ||
'controllers.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be removed after #3377
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for separating this @romilbhardwaj! LGTM.
@@ -64,6 +64,9 @@ class Kubernetes(clouds.Cloud): | |||
'tiers are not ' | |||
'supported in ' | |||
'Kubernetes.', | |||
clouds.CloudImplementationFeatures.HOST_CONTROLLERS: 'Kubernetes can ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc'ing @cblmemo to add clouds that should be black list for hosting the controllers.
Adds
CloudImplementationFeatures.HOST_CONTROLLERS
to check if a cloud supports hosting controllers. cc #3377 #3363Example output with
spot.controller.resources.cloud: Kubernetes
in config.yaml:Tested (run the relevant ones):
bash format.sh
sky spot launch --cloud gcp -- echo hi
with kubernetes and aws controllers.