Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] Add curl and other dependencies in k8s image #3392

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Mar 29, 2024

This is to improve the dependency installation by pinning the version of the dependencies.

master: for i in seq 1 5; do sky launch -y -c test-dep-$i --cloud kubernetes --cpus 1 echo hi; done

1m21s
1m19s
1m22s
1m22s
1m24s

avg: 1m21.6s

this PR: for i in seq 1 5; do sky launch -y -c test-dep-$i --cloud kubernetes --cpus 1 echo hi; done

1m20s
1m27s
1m18s
1m20s
1m17s

avg: 1m20.4s

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll! Has the updated image been pushed to our GCR repo? If yes, is. there a corresponding PR on skypilot-catalog repo to update images.csv? If not, that's okay, we can batch these changes in the next image push we do.

@Michaelvll
Copy link
Collaborator Author

Thanks @Michaelvll! Has the updated image been pushed to our GCR repo? If yes, is. there a corresponding PR on skypilot-catalog repo to update images.csv? If not, that's okay, we can batch these changes in the next image push we do.

We have not pushed to the GCR repo yet. Good catch for the update of images.csv. Let's batch it for the next updated. : )

@Michaelvll Michaelvll merged commit d0f20ab into master Apr 8, 2024
20 checks passed
@Michaelvll Michaelvll deleted the dependency-k8s-image branch April 8, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants