-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add ~/.local/bin to make which ray
work if ray is installed in ~/.local
#3368
Conversation
which ray
work if installed in ~/.local
which ray
work if ray is installed in ~/.local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a question, thanks @Michaelvll.
sky/skylet/constants.py
Outdated
@@ -121,12 +123,18 @@ | |||
# latest ray port 6380, but those existing cluster launched before #1790 | |||
# that has ray cluster on the default port 6379 will be upgraded and | |||
# restarted. | |||
'echo PATH=$PATH; ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for debugging? Worth a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just added the comment.
# previous ray installation happens in user's `~/.local` directory. | ||
# ~/.local/bin is added to the end of PATH to avoid conflicts with ray just | ||
# installed in the conda environment. | ||
'export PATH=$PATH:$HOME/.local/bin; ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand correctly:
- The issue is in some envs, our own Ray is by default installed into ~/.local/bin
- In that env, this path is not in $PATH by default
- So, previously we touch the SKY_RAY_PATH_FILE file, which is empty
- Bug is, later on when we do
our_ray start
,our_ray
is basically empty string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is exactly the issue. Tried to elaborate the comments a bit. PTAL : )
To reproduce:
docker build -t mydockerrepo/image-name:v1 .
;docker push mydockerrepo/image-name:v1
sky launch -c test --image-id docker:mydockerrepo/image-name:v1 echo hi
Another Dockerfile to test:
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
(except TPU tests [Examples] TPU example failexamples/tpu/tpuvm_mnist.yaml
#3425)pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh