[k8s] Fix for spaces and equals signs in docker env vars #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romilbhardwaj
changed the title
Michaelvll
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Awesome! Thanks for the quick fix of this @romilbhardwaj! LGTM.
|
Also ran basic tests with GPU image ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3320. Our parsing for k8s envvars -> ssh envvars would break if the envvar value contained equals signs or spaces. This PR fixes it.
Example, if the env is set as
ENV GIT_SSH_COMMAND="ssh -o HostKeyAlgorithms=+ssh-rsa -o PubkeyAcceptedKeyTypes=+ssh-rsa".Before, our custom envs script would contain:
After (handles equals sign, adds quotes to handle spaces):
Tested (run the relevant ones):
GIT_SSH_COMMANDenvironment variable #3320.