[UX] Reset autostop timer whenever autostop config changes on remote machine #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Example: say a cluster without any autostop set has been idle for 1 hour, |
There was a problem hiding this comment.
Keep/update this scenario?
There was a problem hiding this comment.
The scenario shoud be similar as the new scenario we have. Do you think it is needed to keep this?
There was a problem hiding this comment.
I think it'd help the users/readers. Even though the technical impl is the same, it's "setting autostop for the first time" vs. "resetting autostop" scenarios.
Co-authored-by: Zongheng Yang <[email protected]>
Co-authored-by: Zongheng Yang <[email protected]>
…ot into reset-autostop-timer
concretevitamin
approved these changes
Feb 28, 2024
|
|
||
| Example: say a cluster without any autostop set has been idle for 1 hour, |
There was a problem hiding this comment.
I think it'd help the users/readers. Even though the technical impl is the same, it's "setting autostop for the first time" vs. "resetting autostop" scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1511
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namepytest tests/test_smoke.py::test_autostoppytest tests/test_smoke.py::test_autodownbash tests/backward_comaptibility_tests.sh