-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Fix GCP show-gpus order after combining VM types #3083
Conversation
for info in acc_infos: | ||
info_key = _get_key(info) | ||
if cur_key != info_key: | ||
cur_key = info_key | ||
new_acc_infos.append(info) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we are keeping the first entry in the list. Why is that the cheapest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we have sorted it by the price in L454. : )
Co-authored-by: Tian Xia <[email protected]>
Co-authored-by: Tian Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Left a nit on readability
This seems to slow down
|
This reverts commit 98e92fa.
The current price order for GCP in
sky show-gpus
is incorrect, because:It also fixes #2953.
Tested (run the relevant ones):
bash format.sh
sky show-gpus a100
sky show-gpus a100 --all-regions
sky show-gpus
sky show-gpus v100:1 --all-regions
Before this PR
Note: for example,
asia-east1
has different hourly price, because before this PR we use the same VM price for all different regions which is not correct.pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh