[Minor] Improve completion of accelerator name when cloud is specified #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
approved these changes
Jan 25, 2024
| accelerator_registry.canonicalize_accelerator_name(acc): | ||
| acc_count for acc, acc_count in accelerators.items() | ||
| accelerator_registry.canonicalize_accelerator_name( | ||
| acc, self._cloud): acc_count |
There was a problem hiding this comment.
Minor: What happens if a user has 1 cloud only as indicated by sky check but self._cloud is not specified? I guess we can leave that to the future.
There was a problem hiding this comment.
That is a good point! We can consider inferring the cloud for the whole Resources when only one cloud is enabled. Let's leave it to the future as that may need more test. : )
There was a problem hiding this comment.
Actually, this might be debatable, as this may make an original working yaml fails, if a user add a new cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh