-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc for vSphere provider #3000
Doc for vSphere provider #3000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting the docs for vsphere @changxiaohui! Left several comments. We would also like to change the hint in sky check
to refer to the docs as well:
return False, (
'vSphere dependencies are not installed. '
'Run the following commands:'
f'\n{cls._INDENT_PREFIX} $ pip install skypilot[vSphere]'
f'\n{cls._INDENT_PREFIX}Credentials may also need to be set. '
'For more details. See https://skypilot.readthedocs.io/en/latest/getting-started/installation.html#vmware-vsphere'
f'\n{cls._INDENT_PREFIX}{common_utils.format_exception(e, use_bracket=True)}')
For the place:
skypilot/sky/clouds/vsphere.py
Lines 260 to 266 in f78a16e
return False, ( | |
'vSphere dependencies are not installed. ' | |
'Run the following commands:' | |
f'\n{cls._INDENT_PREFIX} $ pip install skypilot[vSphere]' | |
f'\n{cls._INDENT_PREFIX}Credentials may also need to be set. ' | |
f'{common_utils.format_exception(e, use_bracket=True)}') | |
7fbc6d6
to
33ee835
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the doc @changxiaohui! It looks mostly good to me. It should good to go after the following comments are fixed.
Co-authored-by: Yixing Jia [email protected] Co-authored-by: YongChun Chang [email protected] Co-authored-by: Shiqi He [email protected] Sign-off-by: Yongchun Chang [email protected]
33ee835
to
30d6b3e
Compare
Co-authored-by: Yixing Jia [email protected]
Co-authored-by: YongChun Chang [email protected]
Co-authored-by: Shiqi He [email protected]
Sign-off-by: Yongchun Chang [email protected]