Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkyServe] Check positive for target_qps_per_replica #2995

Merged
merged 1 commit into from
Jan 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sky/serve/service_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ def __init__(
raise ValueError(
'max_replicas must be greater than or equal to min_replicas'
)
if target_qps_per_replica is not None and target_qps_per_replica <= 0:
with ux_utils.print_exception_no_traceback():
raise ValueError(
'target_qps_per_replica must be greater than 0')
if not readiness_path.startswith('/'):
with ux_utils.print_exception_no_traceback():
raise ValueError('readiness_path must start with a slash (/). '
Expand Down