-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SkyServe] Support min_replicas = 0
#2938
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4790dc1
support min_replicas = 0
MaoZiming 87d0106
address pr comments
MaoZiming ad5d524
added a comment
MaoZiming fcf4466
ReplicaStatus.failed_statuses
MaoZiming b22d5a3
return_autoscaler_decision_interval
MaoZiming 941205f
Merge branch 'master' of https://github.com/skypilot-org/skypilot int…
MaoZiming 05534c1
min_replicas_zero.yaml
MaoZiming 8d2cc2b
address code reviews
MaoZiming 5d9e918
update no_replica
MaoZiming 39d90c2
min_replicas_zero.yaml
MaoZiming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# SkyServe YAML to test min_replicas=0 with a simple http server. | ||
# The service will be initialized with no replica (min_replicas = 0). | ||
# Any traffic to the service will trigger an immediate scale-up. | ||
# The service will be scaled down to 0 replica when there is no traffic | ||
# for a long time. | ||
# | ||
# Usage: | ||
# sky serve up -n min_replicas examples/serve/min_replicas_zero.yaml | ||
# The endpoint will be printed in the console. | ||
# Querying the endpoint will trigger a scale up. | ||
|
||
service: | ||
readiness_probe: | ||
path: /health | ||
initial_delay_seconds: 20 | ||
replica_policy: | ||
min_replicas: 0 | ||
max_replicas: 2 | ||
target_qps_per_replica: 1 | ||
|
||
resources: | ||
ports: 8081 | ||
cpus: 2+ | ||
|
||
workdir: examples/serve/http_server | ||
|
||
run: python3 server.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add docstr for how to make the replicas to 0, i.e. don;t send any traffic for how many time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. updated