[Core/AWS] Skip association with no subnetId and fix autodown for spot instances #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
LGTM.
Btw,
sky launch --cloud aws -i0 --down --use-spot -y --region us-east-2
launched successfully but ran into
/Users/zongheng/anaconda/envs/py38/lib/python3.8/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 4 leaked semaphore objects to clean up at shutdown
warnings.warn('resource_tracker: There appear to be %d '
sky.exceptions.NotSupportedError: The following features are not supported by AWS:
Feature Reason
stop Stopping spot instances is currently not supported on AWS.
which appears to be a bug in the last PR (we probably should check --down).
Michaelvll
changed the title
Great catch! Just fixed it in this PR. PTAL. |
concretevitamin
approved these changes
Dec 30, 2023
|
With it now shows the following at the end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2920.
Tested (run the relevant ones):
bash format.shsky launch --cloud aws --region us-west-2 -c test-west --cpus 2 echo hipytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh