Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkyServe] Warn min_replicas = 0 #2895

Merged
merged 1 commit into from
Dec 23, 2023
+2 −3
Merged

[SkyServe] Warn min_replicas = 0 #2895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sky/serve/service_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ def __init__(
post_data: Optional[Dict[str, Any]] = None,
auto_restart: bool = True,
) -> None:
if min_replicas < 0:
if min_replicas <= 0:
with ux_utils.print_exception_no_traceback():
raise ValueError(
'min_replicas must be greater than or equal to 0')
raise ValueError('min_replicas must be greater than 0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add?: Scale-to-zero will be supported in the future.

if max_replicas is not None and max_replicas < min_replicas:
with ux_utils.print_exception_no_traceback():
raise ValueError(
Expand Down