CLI: Deprecate cpunode/gpunode/tpunode, hide admin
#2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Thanks for deprecating the commands @concretevitamin! LGTM.
| @@ -48,7 +50,7 @@ More details can be found on GCP `documentation <https://cloud.google.com/tpu/do | |||
| TPU VMs | |||
| ------- | |||
|
|
|||
| To use TPU VMs, set the following in a task YAML's ``resources`` field: | |||
| To use TPU VMs, set the following in a task YAML's ``resources`` field: | |||
There was a problem hiding this comment.
nit: in the future, we probably need to add the --tpu-vm for sky launch as well.
There was a problem hiding this comment.
Or we can switch the default from tpu nodes to tpu vms @infwinston
Co-authored-by: Zhanghao Wu <[email protected]>
romilbhardwaj
approved these changes
Nov 18, 2023
Comment on lines
+1208
to
+1217
| def _deprecate_and_hide_command(group, command_to_deprecate, | ||
| alternative_command): | ||
| """Hide a command and show a deprecation note, hinting the alternative.""" | ||
| command_to_deprecate.hidden = True | ||
| if group is not None: | ||
| orig = f'sky {group.name} {command_to_deprecate.name}' | ||
| else: | ||
| orig = f'sky {command_to_deprecate.name}' | ||
| command_to_deprecate.invoke = _with_deprecation_warning( | ||
| command_to_deprecate.invoke, alternative_command, orig) |
There was a problem hiding this comment.
should we consider implementing this as a method decorator?
There was a problem hiding this comment.
Either way seems fine to me. This is following L1195 and https://google.github.io/styleguide/pyguide.html#217-function-and-method-decorators :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
cpunode/gpunode/tpunodesky launchessentially does the same thing without the finalsshadminNow
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh