Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Fix Vicuna serve example and add OpenAI Example for Vicuna #2791

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Nov 16, 2023

This PR adds an OpenAI Compatible Endpoint for Vicuna. It also fixed a version issue in our Vicuna example.

This is required for our SkyServe User Doc; I feel like if we could start from an existing example, it would make the understanding easier.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
    • sky launch those two YAMLs and make sure them works
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @cblmemo! Do we need to update the installation for Vicuna training yaml as well?

@cblmemo
Copy link
Collaborator Author

cblmemo commented Nov 16, 2023

Thanks for fixing this @cblmemo! Do we need to update the installation for Vicuna training yaml as well?

I'm not super familiar with the training part of the fastchat... Maybe @infwinston could give some insight here?

@cblmemo cblmemo merged commit 2bc7c6c into master Nov 16, 2023
19 checks passed
@cblmemo cblmemo deleted the vicuna-openai-server branch November 16, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants