-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 Add --zones and --exclude flag to fetch_gcp #2562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sunny0826 for the contribution again! Left some comments.
You may need to add the empty dataframe check to |
I realized that only the relevant GPU information was not found in that Zone, not the VM information, so I added the check to |
If there are no GPUs for a given zone, I think we still want to include both the VM and TPU information, instead of erroring. |
Well, I added checks to both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the effort @sunny0826! This is good to go (just made a minor edit for the comments as discussed).
✅ Closes: #2555
Add
--zones
and--exclude
flag to fetch_gcp.--zones
: Fetch the list of specified zones.--exclude
: Exclude the list of specified regions.