Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version upper bound on pyyaml #2514

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Remove version upper bound on pyyaml #2514

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
252817f
Remove version upper bound on `pyyaml`
steve-marmalade Sep 5, 2023
78e63d9
Disallow `5.4.*` due to incompatibility with cython3
steve-marmalade Sep 5, 2023
ca33242
Update comment for PyYAML pinned versions
steve-marmalade Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions sky/setup_files/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,9 @@ def parse_readme(readme: str) -> str:
# >=1.10.8 is needed for ray>=2.6. See
# https://github.com/ray-project/ray/issues/35661
'pydantic <2.0, >=1.10.8',
# Cython 3.0 release breaks PyYAML installed by aws-cli.
# https://github.com/yaml/pyyaml/issues/601
# https://github.com/aws/aws-cli/issues/8036
steve-marmalade marked this conversation as resolved.
Show resolved Hide resolved
# Cython 3.0 release breaks PyYAML 5.4.* (https://github.com/yaml/pyyaml/issues/601)
# <= 3.13 may encounter https://github.com/ultralytics/yolov5/issues/414
'pyyaml > 3.13, <= 5.3.1'
'pyyaml > 3.13, != 5.4.*'
]

# NOTE: Change the templates/spot-controller.yaml.j2 file if any of the
Expand Down