-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Auto mapping for cluster name #2403
Conversation
…nto auto-mapping-for-cluster-name
…nto auto-mapping-for-cluster-name
Co-authored-by: Tian Xia <[email protected]>
…nto optimize-head-ip
…nto auto-mapping-for-cluster-name
Hey @concretevitamin, thanks for pointing this out! We intentionally truncate the cluster name earlier to 30 chars to avoid the cluster name being too long after appending the job id, which will cause another truncation in the underlying |
Thanks for the detailed review @concretevitamin @cblmemo! I fixed most of the comments. I just realized that we should not tag clusters with original cluster names, as for most of the clouds, tags have the same length limit as cluster names, so I removed the tags. TODO:
|
Just a quick thought - then maybe we could have a column for |
Co-authored-by: Zongheng Yang <[email protected]>
Co-authored-by: Zongheng Yang <[email protected]>
…apping-for-cluster-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @Michaelvll - thanks for this major improvement!
Co-authored-by: Zongheng Yang <[email protected]>
Closes #1853 and Closes #963
The backward compatibility is guaranteed by the restore of ray yaml in the
backend_utils.write_cluster_config
Tested (run the relevant ones):
bash format.sh
sky launch -c i-am-a-very-long-cluster-name-with-more-than-35-characters --cloud gcp --cpus 2
sky status -r
sky exec i-am-a-very-long-cluster-name-with-more-than-35-characters echo hi
sky autostop -i 1 i-am-a-very-long-cluster-name-with-more-than-35-characters
sky status -r
pytest tests/test_smoke.py
pytest tests/test_smoke.py --aws
bash tests/backward_comaptibility_tests.sh