Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Show head ip in sky status -a #2305

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Jul 26, 2023

This PR fixes #1779 by introducing HEAD_IP column in sky status -a.

One example:

(sky-dev) ➜  skypilot git:(show-ip-in-status) ✗ sky status -a
Clusters
NAME             LAUNCHED        RESOURCES              REGION       ZONE           STATUS  AUTOSTOP  HEAD_IP        COMMAND                 
sky-0a05-memory  a few secs ago  1x GCP(n2-standard-8)  us-central1  us-central1-a  UP      -         34.122.179.25  sky launch --cloud gcp  

Managed spot jobs
No in progress jobs. (See: sky spot -h)

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @cblmemo! Left some comments.

sky/utils/cli_utils/status_utils.py Show resolved Hide resolved
sky/utils/cli_utils/status_utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @cblmemo! It should be useful for the case where the user try to launch jupyter notebooks.

@cblmemo cblmemo merged commit 608d0c3 into skypilot-org:master Jul 26, 2023
@cblmemo cblmemo deleted the show-ip-in-status branch July 26, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python interface for getting cluster metadata (e.g., IP)
2 participants