-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SkyServe] Add service schema and change to new service YAML #2267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cblmemo ! The code looks great and I left a few comments.
sky/serve/autoscalers.py
Outdated
@@ -137,8 +140,9 @@ def evaluate_scaling(self): | |||
self.scale_up(1) | |||
self.last_scale_operation = current_time | |||
elif requests_per_node > self.upper_threshold: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if self.upper_threshold
is None
, then we shouldn't run the below code right?
we probably should refactor the code a bit to incorporate fix-node policy and autoscaling policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.. I'll just check if it is None
for now, then if user only specify upper_threshold
, that means user only want to autoscale up and #replica will only increase until reach max_replica
; vise versa for only specify lower_threshold
case. Only if user specified both upper and lower threshold will enable auto sale up/down. We might need a discussion on here.
Close and move to #2276. |
This PR adds a schema checking for our newer version service YAML, and change to new YAML config pattern.
An example:
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh