Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Add network failure handling for Lambda sky check #2221

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

romilbhardwaj
Copy link
Collaborator

If your internet is down (e.g., wifi is off) or lambda cloud is inaccessible, sky check would fail for lambda cloud with a fatal error:

 Checking Lambda...socket.gaierror: [Errno 8] nodename nor servname provided, or not known

During handling of the above exception, another exception occurred:

urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPSConnection object at 0x16d9c7e80>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known

During handling of the above exception, another exception occurred:

urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='cloud.lambdalabs.com', port=443): Max retries exceeded with url: /api/v1/instances (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x16d9c7e80>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known'))

During handling of the above exception, another exception occurred:

requests.exceptions.ConnectionError: HTTPSConnectionPool(host='cloud.lambdalabs.com', port=443): Max retries exceeded with url: /api/v1/instances (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x16d9c7e80>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known'))
(base) ➜  sky-experiments git:(master) ✗ 

After:

  Lambda: disabled          
    Reason: Failed to verify Lambda Cloud credentials. Check your network connection and try again.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • sky check without wifi
  • sky check with wifi

@romilbhardwaj romilbhardwaj changed the title [UX] Add network failure handling for Lambda [UX] Add network failure handling for Lambda sky check Jul 12, 2023
@romilbhardwaj romilbhardwaj merged commit 801a275 into master Jul 13, 2023
@romilbhardwaj romilbhardwaj deleted the lambda_nointernet_fix branch July 13, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants