-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Fail early from provisioning when rsync is uninstalled #2168
[UX] Fail early from provisioning when rsync is uninstalled #2168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix @landscapepainter! We may need to move the check into the upper level?
update error msg Co-authored-by: Zhanghao Wu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Michaelvll Ready for another look. Moved the check to _provision
and doing the check only when it's not a dryrun. Tested with and without --dryrun
flag as well after uninstalling rsync
.
Thanks for the update @landscapepainter! Why do we only check it when it's not a dryrun? I feel like we can have it for the dryrun case as well. Aslo, can we have a separate function for the checking and call that function in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Michaelvll I guess it makes sense if the user can check while dryrun as well. Ready for another look!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @landscapepainter! LGTM. Left two comments.
This PR closes #2113
When
rsync
is not installed in the user's machine,ray_up()
is reattempted for_MAX_RAY_UP_RETRY
number of times without failing. As this is time consuming, this PR fails early in the provisioning step whenrsync
is not installed and gently hints the user to installrsync
.Considered failing from
need_ray_up()
as well, but at this point,state.db
is already updated withINIT
status of the cluster attempted to provisioned which isn't the most optimal scenario. Also, it takes time for single failure before reachingneed_ray_up()
.Tested (run the relevant ones):
bash format.sh
sky launch
after deletingrsync
with and w/o--dryrun
option