Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix key interruption for sky launch #2166

Merged
merged 4 commits into from
Jul 3, 2023
Merged

[Core] Fix key interruption for sky launch #2166

merged 4 commits into from
Jul 3, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jul 1, 2023 •
edited
Loading

Fixes #2163

Tested (run the relevant ones):

@Michaelvll Michaelvll mentioned this pull request Jul 2, 2023
Merged
4 tasks
concretevitamin
concretevitamin approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll! LGTM.

@Michaelvll Michaelvll force-pushed the fix-launch-interrupt-failure branch from bf0f684 to 292703a Compare July 3, 2023 19:04
@Michaelvll Michaelvll merged commit 71431bd into master Jul 3, 2023
@Michaelvll Michaelvll deleted the fix-launch-interrupt-failure branch July 3, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

@romilbhardwaj romilbhardwaj Awaiting requested review from romilbhardwaj

@infwinston infwinston Awaiting requested review from infwinston

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] sky launch failed to be key interrupted
2 participants
@Michaelvll @concretevitamin