Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spot] Fix the handling for spot_recovery: none #2153

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jun 29, 2023

Previously, when spot_recovery: none is provided in the task.yaml, sky launch task.yaml will raise the following error, which is unexpected:

Task from YAML spec: test.yaml
ValueError: Spot recovery strategy NONE is not supported. The strategy should be among ['FAILOVER']

This PR, makes it go through the check when the spot_recovery: none is provided.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test task.yaml with spot_recovery: none provided.
    • sky spot launch --spot-recovery none task.yaml should automatically set the spot_recovery to the default one.
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll merged commit eee216a into master Jun 29, 2023
@Michaelvll Michaelvll deleted the fix-spot-recovery-none branch June 29, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants