-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Add currently activated account for the sky check
and check for disk-tier options
#2114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small UX concern: the name of the argument --all
sounds a little bit confusing and could be misinterpreted as checking all clouds (which implies that the sky check
would only check certain default clouds without this argument). Should we consider using -v
/ --verbose
or exploring other options? 🤔 If there are no better alternatives, the --all
option should be fine.
BTW, shall we update the docs in |
sky check
sky check
and check for disk-tier options
Thanks for the review @cblmemo!
The Also, I just add a option check for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it out. LGTM!
Co-authored-by: Tian Xia <[email protected]>
This PR adds an
--all
option for thesky check
, so that the user could see more details about the enabled cloud, such as the currently activated account.This PR also adds checks for the
--disk-tier
optionTested (run the relevant ones):
bash format.sh
sky check -a
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh