Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: remove two messages from spot launch. #2028

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Minor: remove two messages from spot launch. #2028

merged 1 commit into from
Jun 5, 2023

Conversation

concretevitamin
Copy link
Member

Remove two messages that are printed in the setup part of every spot launch.

Tested (run the relevant ones):

  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

landscapepainter
landscapepainter approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@landscapepainter landscapepainter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@concretevitamin concretevitamin merged commit e0d232f into master Jun 5, 2023
@concretevitamin concretevitamin deleted the spot-launch-echo branch June 5, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landscapepainter landscapepainter landscapepainter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@concretevitamin @landscapepainter