[Core] Fix post teardown error #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romilbhardwaj
approved these changes
Jun 1, 2023
concretevitamin
pushed a commit
that referenced
this pull request
Jun 3, 2023
Fix post teardown error
concretevitamin
pushed a commit
that referenced
this pull request
Jun 4, 2023
Fix post teardown error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #1595 introduced a bug that the post teardown will be executed even though the cluster is terminated already, this should will cause issues for failover when the VM is actually launched.
To reproduce:
sky launch --use-spot --cloud aws --gpus A100:8Tested (run the relevant ones):
sky launch --cloud aws --gpus A100:8 --use-spotpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh