[Spot] Retry until up for spot #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
approved these changes
May 31, 2023
Co-authored-by: Zongheng Yang <[email protected]>
concretevitamin
added a commit
that referenced
this pull request
Jun 3, 2023
* Fix retry-until-up for spot launch * format * abbr * Update sky/cli.py Co-authored-by: Zongheng Yang <[email protected]> * format --------- Co-authored-by: Zongheng Yang <[email protected]>
concretevitamin
added a commit
that referenced
this pull request
Jun 4, 2023
* Fix retry-until-up for spot launch * format * abbr * Update sky/cli.py Co-authored-by: Zongheng Yang <[email protected]> * format --------- Co-authored-by: Zongheng Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when
sky spot launch --retry-until-up echo hiis executed, the retry_until_up will be set to False (weird semantics of the click package). This PR fixes that issue from #1781Tested (run the relevant ones):
sky spot launch --retry-until-up echo hicorrectly warn andretry_until_up is Truesky spot launch --no-retry-until-up echo hicorrectly warn andretry_until_up is Falsesky spot launch echo hino warning andretry_until_up is Truesky spot launch --r echo hicorrectly warn andretry_until_up is Truesky spot launch --no-r echo hicorrectly warn andretry_until_up is Falsepytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh