-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP Storage] Upgrade GCSFuse version #1829
Conversation
Thanks! Should we bump to |
It is Weirdly, the launched the VM is still using |
sky/data/mounting_utils.py
Outdated
installed_check = f'[ -x "$(command -v {mount_binary})" ]' | ||
if version is not None: | ||
installed_check += f' && {mount_binary} --version | grep -q {version}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since not all mounting tools may have --version
flag, can we change the arg version
to version_check_command
and the caller can pass whatever version check command they'd like to run?
E.g., in this case, the caller would pass version_check_command = 'gcsfuse --version | grep -q 1.0'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Fixed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the version check! Should be good to go if pytest tests/test_smoke.py::test_gcp_storage_mounts
passes.
We encountered an issue with the gcsfuse that the saved large model checkpoints on a mounted GCS bucket can be incomplete. It could be a problem with the old gcsfuse we were using:
in the release note of gcsfuse (discovered by @infwinston):
https://github.com/GoogleCloudPlatform/gcsfuse/releases/tag/v0.41.11
Tested (run the relevant ones):
pytest tests/test_smoke.py::test_aws_storage_mounts --aws
; to test the mounting of GCS bucket on AWS VM.pytest tests/test_smoke.py::test_gcp_storage_mounts
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh