-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Enable p4de in the catalog #1827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Michaelvll, some questions.
Also: after users upgrade past this PR, do they need to do anything, or do they have to wait till up to 7 hr for the next catalog refresh? I think it's ok, just checking.
One problem: I ran the fetcher locally, but the fetched catalog doesn't contain any A100-80GB. |
Oops, missed this. Yes, the user does not have to do anything. It will be updated automatically.
That is weird, it works with my account. Could you try the same command as we run in the catalog repo |
succeeded but did not produce A100-80GB.
failed with
Approving for now to unblock potential usage. |
Merging this for now to unblock the users trying AWS for the A100-80GB instances. Let us debug offline @concretevitamin. : ) |
Just confirmed in the catalog repo, the |
Since our AWS credential does not have permission to query the offerings for A100-80GB instances, we now hardcoded it in our
fetch_aws
to unblock the uses of that instance for users.Fixes #1201
Tested (run the relevant ones):
python -m sky.clouds.service_catalog.data_fetchers.fetch_aws
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh