[Spot] Add cancelling state for the spot job #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
suquark
reviewed
Mar 17, 2023
suquark
reviewed
Mar 17, 2023
suquark
approved these changes
Mar 17, 2023
|
Tested:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the #1745, we now set the CANCELLED state after the spot cluster is fully clean up. That will keep the spot job in the previous job for a while, which can feels unresponsive.
Thanks to @suquark 's great idea, we are now adding a CANCELLING state for the spot job to improve the UX.
This will also solve the issue #1745 (comment)
Because, previously, our spot job is not set to terminal state immediately, the log streaming will misclassified it as preempted.
TODOs:
Tested (run the relevant ones):
sky spot launch sleep 600 --cloud gcpandsky spot cancel -acancel it during the starting periodsky spot launch sleep 600 --cloud gcpandsky spot cancel -acancel it during the log is streamingpytest tests/test_smoke.py --managed-spot