Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spot] Disallow
sky down
spot controller when in-progress spot jobs exist #1667[Spot] Disallow
sky down
spot controller when in-progress spot jobs exist #1667Changes from 37 commits
4ae4a2a
f88a408
3786936
fbf720d
bd75460
585b268
b90bf51
8aa176b
7ab8355
c6c0f45
5318c43
a609901
bda6c72
4516596
fcbabd2
d034b0b
cb501a7
555f0ec
5c2d005
903deb9
11ef41c
0ee6703
78696c6
b054f10
cb773ab
087c31b
5d6723b
d3726ed
f524a41
1deab6f
1bf7993
5b43ae9
e1a5536
a7d540a
8db91f1
b4ad820
b1d9b85
da09263
88b151f
b2eb844
16f4400
17833ad
c6389a3
5353f62
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One option, for discussion: we can check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! I changed it to the following. PTAL. : )
![image](https://user-images.githubusercontent.com/6753189/217997444-eeb2a252-f266-4364-8b5f-970027bdfcda.png)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of feel this is a bit too long; was proposing
delete
since it's used in AWS console for certain VPC resources. Wdyt? Feel free to do a poll too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I used the
I understand
because that will remind the user to read the messages above, but I am not feeling strongly about this. Switched back todelete
.