[Image] Check image size and existence #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is great @Michaelvll! Took a pass and left some comments. Haven't tested yet.
romilbhardwaj
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Tested with some simple manual tests - works great! Thanks for adding @Michaelvll!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this PR:
This PR adds the check for the image size and existence, so that any problematic image id will fail early. It should also fix #1506
Tested (run the relevant ones):
sky launch --cloud aws --region us-east-1 --image-id ami-nonexistsky launch --cloud aws --region us-east-1 --image-id skypilot:non-existsky launch --cloud aws --image-id skypilot:non-existsky launch --cloud gcp --image-id project/nonexistsky launch --cloud gcp --region us-east1 --image-id project/nonexistsky launch --cloud aws --image-id ami-0729d913a335efca7 --region us-east-1 --disk-size 40ValueError: Image 'ami-0729d913a335efca7' is 45GB, which is larger than the specified disk_size: 40 GB. Please specify a larger disk_size.sky launch --cloud gcp --image-id projects/deeplearning-platform-release/global/images/common-cu113-v20220701 --disk-size 40ValueError: Image 'projects/deeplearning-platform-release/global/images/common-cu113-v20220701' is 50.0GB, which is larger than the specified disk_size: 40 GB. Please specify a larger disk_size.sky spot launch --cloud aws --image-id ami-0729d913a335efca7 --region us-east-1 --disk-size 40 echo hiValueError: Image 'ami-0729d913a335efca7' is 45GB, which is larger than the specified disk_size: 40 GB. Please specify a larger disk_size.bash tests/run_smoke_tests.sh(except [Storage] Uploading list of files to bucket fails #1510, and test_spot due to the autostop of the controller)