Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints for spot controller in sky status output. #1467

Merged
merged 8 commits into from
Dec 3, 2022
+8 −4
Merged

Hints for spot controller in sky status output. #1467

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
13d6950
Hints for spot controller in `sky status` output.
concretevitamin Nov 29, 2022
323f0dd
Update hint.
concretevitamin Nov 30, 2022
8fb14f1
Update message.
concretevitamin Nov 30, 2022
6cc7713
Reword
concretevitamin Dec 1, 2022
3a6a8a1
Reorder
concretevitamin Dec 1, 2022
b3e29c4
pylint
concretevitamin Dec 1, 2022
2a47aaf
Reword
concretevitamin Dec 3, 2022
a70345a
Remnant.
concretevitamin Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sky/backends/cloud_vm_ray_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2223,7 +2223,7 @@ def _exec_code_on_head(
'\nTo cancel the job:\t\t'
f'{backend_utils.BOLD}sky spot cancel {job_id}'
f'{backend_utils.RESET_BOLD}'
'\nTo stream the logs:\t\t'
'\nTo stream job logs:\t\t'
f'{backend_utils.BOLD}sky spot logs {job_id}'
f'{backend_utils.RESET_BOLD}'
f'\nTo stream controller logs:\t'
Expand All @@ -2238,7 +2238,7 @@ def _exec_code_on_head(
'\nTo cancel the job:\t'
f'{backend_utils.BOLD}sky cancel {name} {job_id}'
f'{backend_utils.RESET_BOLD}'
'\nTo stream the logs:\t'
'\nTo stream job logs:\t'
f'{backend_utils.BOLD}sky logs {name} {job_id}'
f'{backend_utils.RESET_BOLD}'
'\nTo view the job queue:\t'
Expand Down
2 changes: 1 addition & 1 deletion sky/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2770,7 +2770,7 @@ def _is_spot_controller_up(

@cli.group(cls=_NaturalOrderGroup)
def spot():
"""Managed spot instances related commands."""
"""Commands for managed spot jobs."""
pass


Expand Down
8 changes: 7 additions & 1 deletion sky/utils/cli_utils/status_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,15 @@ def show_status_table(cluster_records: List[Dict[str, Any]],
autostop_minutes = spot.SPOT_CONTROLLER_IDLE_MINUTES_TO_AUTOSTOP
click.echo(f'\n{colorama.Fore.CYAN}{colorama.Style.BRIGHT}'
f'{reserved_group_name}{colorama.Style.RESET_ALL}'
f'{colorama.Style.DIM} (will be autostopped if idle for '
f'{colorama.Style.DIM} (autostopped if idle for '
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: autostopped alone does not have a clear meaning to me. Not sure if other people have the same feeling.

f'{autostop_minutes}min)'
f'{colorama.Style.RESET_ALL}')
reset = backend_utils.RESET_BOLD
click.echo(
f'{colorama.Style.DIM} Directly interacting with the '
f'controller is typically not needed.{colorama.Style.RESET_ALL}'
'\n Use spot jobs CLI: '
f'{colorama.Style.BRIGHT}sky spot --help{reset}')
else:
click.echo(f'{colorama.Fore.CYAN}{colorama.Style.BRIGHT}Clusters'
f'{colorama.Style.RESET_ALL}')
Expand Down