Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ux_utils.print_exception_no_traceback() for Cleaner Error Output #4096

Closed
andylizf opened this issue Oct 16, 2024 · 0 comments · Fixed by #4111
Closed

Add ux_utils.print_exception_no_traceback() for Cleaner Error Output #4096

andylizf opened this issue Oct 16, 2024 · 0 comments · Fixed by #4111

Comments

@andylizf
Copy link
Collaborator

Add ux_utils.print_exception_no_traceback() to all errors in the serve_utils.py file to simplify console output and reduce traceback clutter. This will make error messages more user-friendly and easier to read.

          It would be great if you can help adding this to other errors raised in this file, in a separate PR ;)

Originally posted by @cblmemo in #4032 (comment)
andylizf added a commit to andylizf/skypilot that referenced this issue Oct 17, 2024
@andylizf
Add ux_utils.print_exception_no_traceback() for cleaner error output
5f1a1a0 
Fixes skypilot-org#4096

Add `ux_utils.print_exception_no_traceback()` to error handling blocks in `sky/serve/serve_utils.py` to simplify error messages and reduce traceback clutter.

* Add `ux_utils.print_exception_no_traceback()` to the error handling block in the `set_service_status_and_active_versions_from_replica` function.
* Add `ux_utils.print_exception_no_traceback()` to the error handling block in the `_get_service_status` function.
* Add `ux_utils.print_exception_no_traceback()` to the error handling block in the `update_service_encoded` function.
* Add `ux_utils.print_exception_no_traceback()` to the error handling block in the `check_service_status_healthy` function.
* Add `ux_utils.print_exception_no_traceback()` to the error handling block in the `stream_replica_logs` function.
@andylizf andylizf mentioned this issue Oct 17, 2024
Merged
@Michaelvll Michaelvll added the OSS label Dec 19, 2024 — with Linear
@Michaelvll Michaelvll removed the OSS label Dec 19, 2024
@Michaelvll Michaelvll added the OSS label Dec 19, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Serve] Add ux_utils.print_exception_no_traceback() for cleaner error output andylizf/skypilot
2 participants
@Michaelvll @andylizf