wip: looking for feedback #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dissecting the integration steps for RunPod and others.
There was a problem hiding this comment.
Looks great, thanks a bunch for these updates @justinmerrell! Left some minor nits.
Co-authored-by: Zongheng Yang <[email protected]>
Co-authored-by: Zongheng Yang <[email protected]>
Co-authored-by: Zongheng Yang <[email protected]>
Co-authored-by: Zongheng Yang <[email protected]>
concretevitamin
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Thanks a bunch for this @justinmerrell! Going forward it's going to help new clouds :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I am working on the RunPod integration, I am migrating the info from the Google Doc to this repo as well as cleaning up some of the examples.
Still a work in progress, but looking for feedback on what I have thus far.
For the example files, I am using
FILL_INvsTODOas the first time I looked at the examples, I misinterpreted "TODO" with incomplete examples that needed work from the managers vs something I was supposed to fill out.