Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jadx-gui as a library in plugins #2310

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Conversation

nitram84
Copy link
Contributor

For my latest plugin (https://github.com/nitram84/jadx-apkspy-plugin) I needed a compile dependency to jadx-gui. To build jadx-gui as a library I had to fix some issues, mostly javadoc issues. I'd like to remove this workaround for my plugin, so I would like to propose my changes as a PR.

@skylot
Copy link
Owner

skylot commented Oct 22, 2024

@nitram84 I also add jadx-library for jadx-cli and jadx-script-ide modules because jadx-gui depends on them and gradle build fail if unable to find these.
Although, if anyone tries to start JadxGui from this library and opens preferences, app will crash with class not found error for JFontChooser. This class from jar in jadx-gui/libs, so it is not uploaded into maven. This is minor issue, and I will fix it later.

Anyway, using jadx-gui as a library should be used only as a workaround. Because code in jadx-gui often changes and this can break plugins 😢

@skylot skylot merged commit 8a34d97 into skylot:master Oct 22, 2024
4 checks passed
@skylot
Copy link
Owner

skylot commented Oct 22, 2024

1.5.1-SNAPSHOT updated, please check if everything is working fine 🙂

@nitram84
Copy link
Contributor Author

@skylot Thank you for your work! Everything is working fine.
I don't have a problem if changes in jadx-gui break things in plugins - I'm sure there is a way to fix it in the plugin. Anyway my plugin is just a proof of concept to test if #2215 can be fixed with a plugin approach.

@nitram84 nitram84 deleted the jadx_gui_lib branch December 3, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants