Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add button to go to Android Manifest #2296

Merged
merged 2 commits into from
Oct 10, 2024
Merged

feat: Add button to go to Android Manifest #2296

merged 2 commits into from
Oct 10, 2024

Conversation

xiaojye
Copy link
Contributor

@xiaojye xiaojye commented Oct 9, 2024 •
edited
Loading

@xiaojye xiaojye mentioned this pull request Oct 9, 2024
Closed
@jpstotz
Copy link
Collaborator

jpstotz commented Oct 9, 2024

As Jadx can not only process Android apps but also regular Java code the name "Go to Manifest" may be misleading, as a non-Android developer would interpret it as "Go to META-INF/MANIFEST.MF". Therefore I would recommend to change it in strings to the full name "AndroidManifest.xml" respectively in code to "AndroidManifest".

MrIkso
MrIkso reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@MrIkso MrIkso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use icon from intellij-icons.jetbrains.design, all icons in jadx used from here.

@xiaojye
Copy link
Contributor Author

xiaojye commented Oct 10, 2024 •
edited
Loading

As Jadx can not only process Android apps but also regular Java code the name "Go to Manifest" may be misleading, as a non-Android developer would interpret it as "Go to META-INF/MANIFEST.MF". Therefore I would recommend to change it in strings to the full name "AndroidManifest.xml" respectively in code to "AndroidManifest".

Good suggestion, optimized and modified. Please refer to the latest commit https://github.com/skylot/jadx/pull/2296/commits/ffaefd2c3cc6469d62ee80b144a1c23c78e87644

@xiaojye
Copy link
Contributor Author

xiaojye commented Oct 10, 2024 •
edited
Loading

Use icon from intellij-icons.jetbrains.design, all icons in jadx used from here.

Good suggestion, optimized and modified. Please refer to the latest commit https://github.com/skylot/jadx/pull/2296/commits/ffaefd2c3cc6469d62ee80b144a1c23c78e87644

skylot
skylot approved these changes Oct 10, 2024
View reviewed changes
Copy link
Owner

@skylot skylot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@skylot skylot merged commit 3ed2df8 into skylot:master Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrIkso MrIkso MrIkso left review comments

@skylot skylot skylot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Go to Android Manifest
4 participants
@xiaojye @jpstotz @skylot @MrIkso