Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Usage of registers in enum declarations #1686

Closed
bagipro opened this issue Sep 28, 2022 · 1 comment
Closed

[core] Usage of registers in enum declarations #1686

bagipro opened this issue Sep 28, 2022 · 1 comment
Labels
bug Core Issues in jadx-core module

Comments

@bagipro
Copy link
Collaborator

bagipro commented Sep 28, 2022

Hey!

APK: https://drive.google.com/file/d/1XBpFGkIORvQkPu8sYaWFpSZ1ZI87QpxR/view?usp=sharing

File com/samsung/context/sdk/samsunganalytics/internal/connection/Domain.java

public enum Domain {
    REGISTRATION(Utils.isEngBin() ? r2 : "https://regi.di.atlas.samsung.com"),
    POLICY(r2),
    DLS("");
    
    String domain;

    static {
        String str = "https://stg-api.di.atlas.samsung.com";
        if (!Utils.isEngBin()) {
            str = "https://dc.di.atlas.samsung.com";
        }
    }

I believe that there shouldn't be the static block, but str should be initialized with "https://stg-api.di.atlas.samsung.com"

@bagipro bagipro added bug Core Issues in jadx-core module labels Sep 28, 2022
@skylot
Copy link
Owner

skylot commented Oct 7, 2022

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module
Projects
None yet
Development

No branches or pull requests

2 participants