Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core]The recognized class name is wrong, resulting in generated frida and xposed code using the wrong class name #1578

Closed
bhwxha opened this issue Jul 14, 2022 · 3 comments
Labels

Comments

@bhwxha
Copy link

bhwxha commented Jul 14, 2022

link: https://drive.google.com/file/d/13OflkLZUEUXDYqxwujTVCwqEuLy2IRZW/view?usp=sharing
Method Name:a.a.a.a$c.run()

The class is a.a.a.a$c, but jadx recognizes it as a.a.a.a.
This also causes the generated frida code and xposed code to use the wrong class name.

image

@bhwxha bhwxha added bug Core Issues in jadx-core module labels Jul 14, 2022
@jpstotz
Copy link
Collaborator

jpstotz commented Jul 14, 2022

Thanks for reporting and for the sample dex file. This a nice and small sample code. May be it is time to set-up some unti-tests to ensure correctness of the different snippets that can be generated.

@skylot
Copy link
Owner

skylot commented Jul 14, 2022

@jpstotz this issue not actually related to frida/xposed snippets, this is an issue in jadx core of incorrect processing of moved/inlined classes (related to #1422), through this method not moved but code incorrectly calculate a class parent (got an additional 'parent'). I commit a fix for that, please check it, because it can bring regressions. And I definitely need more test cases for jadx core API 😢

@bhwxha
Copy link
Author

bhwxha commented Jul 15, 2022

The class name is currently displayed correctly in this location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants