Stats Model and Database Update #181
Open
+418
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tats layout into its own xml file to make the implementation of comparing two pokemon's attributes easier in a future pull request. 2. Implement the pokeapi's stats field into the relevant core-model and core-database files to facilitate pulling from those stats rather than randomly generating stats for each Pokemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulate the stats ui into its UI Layout/XML file. Although this introduces additional nesting layouts, it facilitates additional re-use of the stats ui across other parts of the application, such as if developers want to add a feature to compare stats amongst multiple Pokemon, or compare an individual Pokemon's stats as it levels up.
Implement the PokeAPI's stats field into the relevant core-model and core-database files to facilitate pulling from those stats dynamically rather than randomly generating a Pokemon's stats when the application is loaded.
As of yet, these are just some the fundamental changes needed to prepare the application for actually implementing new stats related features. Accordingly, this pull request does not yet implement proper data binding for the new stats fields.