Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-node config gen #1783

Merged
merged 1 commit into from
Mar 21, 2024
Merged

setup-node config gen #1783

merged 1 commit into from
Mar 21, 2024

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented Mar 21, 2024

Fixes # 1761

@0pcom
Copy link
Collaborator Author

0pcom commented Mar 21, 2024

$ go run cmd/skywire/skywire.go cli config gen --sn -n
{
    "dmsg": {
        "discovery": "http://dmsgd.skywire.skycoin.com",
        "servers": [],
        "sessions_count": 2
    },
    "log_level": "",
    "public_key": "030f21ddb74148af74b8444c3de53c6304bfcb2d4550336fd9196654c12ccf9349",
    "secret_key": "dc6e5b014369d74296ebc81457ee2d3b60f4705cce43bb4e8b063b530537f3be",
    "transport_discovery": "http://tpd.skywire.skycoin.com"
}

image

@mrpalide
Copy link
Contributor

Is not better use standard struct for sn config instead jq and script to create it?

@0pcom
Copy link
Collaborator Author

0pcom commented Mar 21, 2024

Is not better use standard struct for sn config instead jq and script to create it?

I'm literally just filtering the output down. I think it would be better to not have the flag on config gen and to make the setup-node work with the visor config.

the fields are the same for setup-node as for the visor, but there are extra ones in the visor config.

The script library isn't using any external dependencies here. It uses go-jq which I quite like.

This was just supposed to be a simple and quick fix. It does work, but we can put more thought later into changing this to be different or making setup-node able to use the visor's config.

@mrpalide mrpalide merged commit 43b4c15 into skycoin:develop Mar 21, 2024
3 checks passed
@0pcom 0pcom mentioned this pull request Mar 21, 2024
@0pcom 0pcom deleted the sn-conf-gen branch March 24, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants