Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track Provider resource state #445

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Track Provider resource state #445

wants to merge 14 commits into from

Conversation

alexgeorgousis
Copy link
Contributor

@alexgeorgousis alexgeorgousis commented Jan 22, 2025 •
edited
Loading

Closes #443

Tasks

  • Set SynchronizationState on Provider resource
    • Write decoupled tests for all state transitions
    • Current problematic scenario: failing deployment and then fixing it (add a test case for it)
    • Case to cover: What if Creating -> Deployment create operation fails -> Failed -> Creating -> ... forever
    • We don't cover failure scenarios in the pipeline decoupled tests - probably want some right?
  • Set Synchronized condition (we do this for all other resources)???
  • What about ObservedGeneration? (It's on the CRD but we never set it explicitly)
  • Set events on provider resource
  • Add/update integration tests if needed

alexgeorgousis and others added 14 commits January 22, 2025 13:29
@alexgeorgousis
Add Provider controller
e29c54e
@TobyPinfold @alexgeorgousis
Add overrides within provider deployment construction and drop use of…
5501690 
… mounted configmap volume to override provider behaviour
@aidandunlop @alexgeorgousis
use owner references to find correct provider depoloyment and make pr…
0a1db32 
…oviders own deployments
@peter-hazell @alexgeorgousis
Removed Serving from Status and aligned kustomize with helm
715fe16
@alexgeorgousis
Set up logging first thing in main.go
f6323ef 
This was causing errors while loading config to not be logged!
@alexgeorgousis
Fix provider config syntax error
bc2521f
@alexgeorgousis
Grant controller-manager permissions to manage Deployments
099309e
@alexgeorgousis
Rename Image -> ServiceImage in Provider CRD
b083181
@alexgeorgousis
Remove provider helm chart
76d3443
@alexgeorgousis
Fix provider Deployment creation and provider service start up with c…
98f4120 
…onfig loading
@grahamia @alexgeorgousis
Add resource hash annotation on Deployment
20a1060
@grahamia @alexgeorgousis
Allowing ability to mount volumes in the provider deployment
804b5e5
@peter-hazell @alexgeorgousis
WriteObject unit test and correctly get the string value for the reso…
c55328a 
…urce hash
@alexgeorgousis
WIP: Set Provider SynchronizationState
ef01848
@alexgeorgousis alexgeorgousis changed the title Provider state handling Track Provider resource state Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track Provider resource state
5 participants
@alexgeorgousis @TobyPinfold @aidandunlop @peter-hazell @grahamia