Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow sorting of nodes by Seen column in Orphaned view by populating Epoch for orphaned nodes #82

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

corporate-gadfly
Copy link
Contributor

@corporate-gadfly corporate-gadfly commented May 4, 2021

@skx : Thanks in advance for merging this pull request. I know you had earlier said that you no longer have a working puppet environment.

  • this PR allows sorting of nodes by Seen column in the Orphaned view

- this will allow sorting of nodes by Seen column in the Orphaned view
@corporate-gadfly corporate-gadfly changed the title populate Epoch for orphaned nodes allow sorting of nodes by Seen column in Orphaned view by populating Epoch for orphaned nodes May 4, 2021
@skx
Copy link
Owner

skx commented May 5, 2021

I'm happy to merge PRs and talk about issues, I just don't have any need for running this software myself any more.

Looks like a nice simple change, thanks for your contribution :)

@skx skx merged commit 8e4f7ca into skx:master May 5, 2021
@corporate-gadfly
Copy link
Contributor Author

TY. This PR also fixed sorting of orphaned nodes on the All tab.

@skx
Copy link
Owner

skx commented May 7, 2021

Thanks for the clarification; if you've nothing else pending I'll make a new release over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants