-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for Pytest 7.0.0 stacktrace normalization bug #49
Conversation
145f6ed
to
f3190e8
Compare
pytest 7.0.1 came out today, containing a fix |
This is no longer necessary. I still think that the changes in the PR are nice and helpful, but now it is not fixing anything. I'll close this in a few days if there is no feedback. |
f3190e8
to
dac605b
Compare
The changes LGTM - one question: these changes imply that TestCases should call setUp() instead of using an init method. So going forward should we avoid using init in favor of setUp? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes do improve the code regardless.
I think so. Defining Going further forward, I'd consider using Pytest ways of doing things, exclusively, with the proviso that some custom work is needed to make integration/system testing convenient (pytest-dev/pytest#9141, but current python unittest suffers from the same problem, or lack of feature, to be precise.) |
dac605b
to
0c8acc1
Compare
…d of __init__ in tests This started as a workaround for Pytest 7.0.0 stacktrace normalization bug pytest-dev/pytest#9610
0c8acc1
to
83b2cac
Compare
…d of __init__ in tests This started as a workaround for Pytest 7.0.0 stacktrace normalization bug pytest-dev/pytest#9610
83b2cac
to
4c4eaf0
Compare
…d of __init__ in tests This started as a workaround for Pytest 7.0.0 stacktrace normalization bug pytest-dev/pytest#9610
4c4eaf0
to
367a9ad
Compare
Workarounds pytest-dev/pytest#9610