This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
Scroll to groups #24
Merged
Scroll to groups #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform actual scroll to group after current tab has been updated and is visible in the DOM. In this way it can get the actual offset of the group and scroll after changing the tab. Previously it changed tab but didn't scroll down to group as it return offset = 0; The getScrollPositionFor returns a timeout promise, with the group offset after it has been made visible.
|
Hi, |
|
Works like a charm thanks :) Funny thing is, I do actually have the id on my local environment, just forgot to push it 😳 |
|
Lol! 😂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a missing id to the groups so they can be found by id.
Also, made the actual scroll perform after a timeout promise, so it gets the right offset of the tab group after the cycle has completed and the group is visible in the DOM.