-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] isolate pytorch-optimizer
as soft dependency
#1641
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
+ Coverage 90.10% 90.14% +0.04%
==========================================
Files 32 32
Lines 4768 4780 +12
==========================================
+ Hits 4296 4309 +13
+ Misses 472 471 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Isolates
pytorch-optimizer
as soft dependency in a new soft dep setall_extras
. #1616The imports happen only in
BaseModel
, when resolving aliases foroptimizer
.Isolation consists of two steps:
"ranger"
with"adam"
ifpytorch-optimizer
is not installed (left at"ranger"
if installed)Deprecation messages and actions are added, to changne the default to
"adam"
from 1.2.0, in order to minimize the number of dependencies in default parameter settings