Add SecretFilesPreprocessor to add secrets into configs referenced from a dir #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts or feedback on this? |
|
@Bengreen how do mounted secrets work in K8? Is it a secret per file or something ? |
|
Yes.
The secret is held in k8s as a set of kv pairs that are then mounted to the
desired mount path of the container. Each value results in a file. You can
have hierarchy of dirs or all in one dir.
KR, Ben
…On Sun, Feb 2, 2025, 19:30 Sam ***@***.***> wrote:
@Bengreen <https://github.com/Bengreen> how do mounted secrets work in
K8? Is it a secret per file or something ?
—
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGSVPAXLZD6HBGO5OUTAR32NZW4BAVCNFSM6AAAAABVO5R2NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGUZDIMZVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Preprocessor to load values into the config from files specified within a defined directory. This allows secrets to be separated from config (following 12 factor app and similar).
A typical usage is when running in a Kubernetes pod and the credentials are provided through a mount point. Using this preprocessor we can load the credentials from the files in the secrets directory into the config. The mount point of the secrets needs to be provided to the Preprocessor as a base dir. This is envisioned to be provided via a command line arg or similar run-time specific setting.